Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a homegrown Accordion Component #136

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Build a homegrown Accordion Component #136

merged 6 commits into from
Nov 25, 2024

Conversation

aaronbrethorst
Copy link
Member

@aaronbrethorst aaronbrethorst commented Nov 25, 2024

  • Sticky route schedule headers have a gap above them
  • The datepicker appears behind the sticky headers
  • On load, the schedules should not animate open — i.e. add an option to open without animation and use it on first page load.
  • All schedules should be expanded by default
  • The accordion should support showing multiple items at once
  • Show all routes/Collapse all routes buttons aren't working

...and use it on the schedule page. By extracting the inner component from the accordion item, we decouple some implementation details of the Flowbite accordion from this piece of UI, and allow ourselves to further reuse it elsewhere if and when we need to.

This commit is a WIP.

- [ ] Show all routes/Collapse all routes buttons aren't working
- [ ] Sticky route schedule headers have a gap above them
- [ ] The datepicker appears behind the sticky headers
- [ ] All schedules should be expanded by default
Also adds explicit methods for opening and closing all accordion items to our new Accordion component, and wires them up to the Schedule page. Also open all items by default.
@aaronbrethorst aaronbrethorst changed the title More Fit and Finish Build a homegrown Accordion Component Nov 25, 2024
@aaronbrethorst aaronbrethorst marked this pull request as ready for review November 25, 2024 04:24
@aaronbrethorst aaronbrethorst merged commit 607b394 into main Nov 25, 2024
3 checks passed
@aaronbrethorst aaronbrethorst deleted the more-fnf branch November 25, 2024 04:26
@Ahmedhossamdev
Copy link
Member

Great work Aaron!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants